feat(core): enhances create message input types#16
Merged
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR refines the createCommand, createQuery, and createEvent input types to improve compile-time type safety by making the input types generic and tying fields like data (and potentially type) to the provided message subtype.
Changes:
- Make
CreateCommandInput,CreateQueryInput, andCreateEventInputgeneric sotype/source/datareflect the chosenT*message type. - Refactor
createCommand/createQuery/createEventto accept a singleinputparameter and build the message from it. - Fix a documentation spelling typo in
event.ts(“incomming” → “incoming”).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/core/src/lib/message/query.ts | Makes CreateQueryInput generic and updates createQuery to use the new typed input object. |
| packages/core/src/lib/message/event.ts | Makes CreateEventInput generic, refactors createEvent input handling, and fixes a doc typo. |
| packages/core/src/lib/message/command.ts | Makes CreateCommandInput generic and updates createCommand to use the new typed input object. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhances the input type for
createCommand,createQueryandcreateEventfor better type safety and validation.